Add cleanup tasks to resolve Grafana apt repository conflict#782
Open
Add cleanup tasks to resolve Grafana apt repository conflict#782
Conversation
dmick
reviewed
Jul 16, 2025
roles/grafana_agent/tasks/main.yml
Outdated
| state: absent | ||
| when: ansible_pkg_mgr == "apt" | ||
|
|
||
| - name: Remove existing Grafana APT repository |
Member
There was a problem hiding this comment.
Will this remove and recreate the repo every time? Is there a way to make this conditional?
Contributor
There was a problem hiding this comment.
@dmick I agree this is a bit bruteforce-y but it does prevent us from having to maintain some sort of sha or verification about the key. What is your concern? Security? Messing with apt cache?
Member
There was a problem hiding this comment.
just wasted work. I guess I thought that we could set a variable if we found and removed the .key file at least. Not a big deal.
akraitman
force-pushed
the
wip-remove-old-grafana-repo-and-gpg-key
branch
from
e896eb3 to
d5f8b97
Compare
djgalloway
reviewed
Jul 17, 2025
djgalloway
reviewed
Jul 17, 2025
The new tasks remove the conflicting key file and duplicate repository entries before adding the standardized Grafana repository, ensuring a clean APT configuration Signed-off-by: Adam Kraitman <akraitma@li-8b09b2cc-35b7-11b2-a85c-cd1dbade58f9.ibm.com>
akraitman
force-pushed
the
wip-remove-old-grafana-repo-and-gpg-key
branch
from
d5f8b97 to
5288aec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new tasks remove the conflicting key file and duplicate repository entries before adding the standardized Grafana repository, ensuring a clean APT configuration